Merged
Conversation
Collaborator
smahdavi4
commented
Aug 7, 2025
smahdavi4
commented
- Adding reasoning effort to vllm models (particularly targetting gpt-oss)
- Make random_seed None by default (to encourage randomness for people not using it)
- Disallow more parameters in text completion
smahdavi4
force-pushed
the
improve-client
branch
from
342172c to
e50271e
Compare
Signed-off-by: Sadegh Mahdavi <smahdavi@nvidia.com>
smahdavi4
force-pushed
the
improve-client
branch
from
e50271e to
fe5a659
Compare
i-vainn
pushed a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: Sadegh Mahdavi <smahdavi@nvidia.com> Signed-off-by: i-vainn <1vanmoshkov@mail.ru>
wasiahmad
pushed a commit
that referenced
this pull request
Oct 1, 2025
Signed-off-by: Sadegh Mahdavi <smahdavi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.